Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up environment variables #258

Merged
merged 1 commit into from
Aug 5, 2022
Merged

clean up environment variables #258

merged 1 commit into from
Aug 5, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Aug 4, 2022

Changes

  • Removes the unneeded Zipkin reference from Jaeger
  • Cleans up the definition of the OTLP Endpoint and related environment variables
  • Uses the OpenTelemetry standard OTEL_SERVICE_NAME environment variable for all service names (except for C++)

@puckpuck puckpuck requested a review from a team August 4, 2022 21:11
@cartersocha cartersocha merged commit a4e258c into open-telemetry:main Aug 5, 2022
@puckpuck puckpuck deleted the cleanup-environment-variables branch August 5, 2022 01:55
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck
clean up environment variables (open-telemetry#258)
96e916b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puckpuck @reyang @cartersocha