Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[paymentservice] Add missing dependencies #217

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

julianocosta89
Copy link
Member

No issue was opened, but I brought this up in slack: https://cloud-native.slack.com/archives/C03B4CWV4DA/p1657607127541249

When running the demo in WSL the paymentservice didn't have spans in Jaeger.

Changes

  • Updated the OTel packages version
  • Added the following missing dependencies:
    • "@grpc/proto-loader"
    • "@opentelemetry/api"

@julianocosta89 julianocosta89 requested a review from a team July 19, 2022 19:20
@cartersocha cartersocha merged commit 7e71695 into open-telemetry:main Jul 21, 2022
@julianocosta89 julianocosta89 deleted the FIX-PaymentService branch July 22, 2022 04:47
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants