Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push image to dockerhub #184

Merged

Conversation

wph95
Copy link
Member

@wph95 wph95 commented Jul 3, 2022

fix #78
github action add push docker image to dockerhub

@wph95 wph95 requested a review from a team July 3, 2022 22:39
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wph95 👋🏽

Shouldn't we use the OTel registry now?
The image names used in the file are:

  • ghcr.io/wph95/demo
  • otelbot/demo

Is that correct?

@wph95
Copy link
Member Author

wph95 commented Jul 4, 2022

Hello @wph95 👋🏽

Shouldn't we use the OTel registry now? The image names used in the file are:

  • ghcr.io/wph95/demo
  • otelbot/demo

Is that correct?

fixed it

https://github.com/open-telemetry/community/blob/main/assets.md#docker-hub
our dockerhub account is "otelbot"

  • ghcr.io/open-telemetry/demo
  • otelbot/demo

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julianocosta89 julianocosta89 self-requested a review July 4, 2022 06:20
@wph95 wph95 requested a review from arminru July 4, 2022 17:18
@cartersocha cartersocha merged commit 18a4846 into open-telemetry:main Jul 5, 2022
@cartersocha
Copy link
Contributor

Thanks @wph95!

@wph95 wph95 deleted the github-action-push-image-to-dockerhub branch July 5, 2022 23:00
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI workflow to Docker Hub
4 participants