-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
push image to dockerhub #184
push image to dockerhub #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @wph95 👋🏽
Shouldn't we use the OTel registry now?
The image names used in the file are:
- ghcr.io/wph95/demo
- otelbot/demo
Is that correct?
fixed it https://github.com/open-telemetry/community/blob/main/assets.md#docker-hub
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Armin Ruech <[email protected]>
Thanks @wph95! |
* push image to dockerhub
fix #78
github action add push docker image to dockerhub