Add list of all manual attributes #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianocosta89
force-pushed
the
list-of-manual-attributes
branch
from
af2b5e9 to
f210168
Compare
|
Lgtm. Thanks for doing this |
cartersocha
approved these changes
Jul 2, 2022
Me too 😅 |
|
Should we shift the generic feature tables to separate centralized docs too? Align it by traces, metrics, logs? Then just update in one place |
|
Which generic feature tables? |
|
We can work on consolidating more in a separate PR -- this seems good to go, merging. |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* Add list of all manual attributes * sanity check * Add CartService spans Co-authored-by: Carter Socha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the services being instrumented manually, it would be great if we could keep the span attributes documented.
I've went through all services and the opened PRs to create the initial file.
From this, we can keep it updated whenever new PRs arrive, and we can follow a naming convention across all services.