Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update emoji / add payment feature table #165

Merged
merged 3 commits into from
Jun 23, 2022
Merged

update emoji / add payment feature table #165

merged 3 commits into from
Jun 23, 2022

Conversation

cartersocha
Copy link
Contributor

change emoji to improve readability.

Add payment feature table

@cartersocha cartersocha requested a review from a team June 23, 2022 04:03
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a general suggestion - could we move the emoji to the beginning of the line?

Currently it looks like:

image

I personally find it more readable if it looks like:

image

@cartersocha cartersocha merged commit 3609e71 into open-telemetry:main Jun 23, 2022
@cartersocha cartersocha deleted the doc-updates-color-payment branch June 23, 2022 23:37
GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
* update emoji / add payment table

* switch emoji order

* sanity fix
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* update emoji / add payment table

* switch emoji order

* sanity fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants