Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add depends_on to almost components #138

Merged
merged 3 commits into from
Jun 16, 2022

Conversation

Frapschen
Copy link
Contributor

add depends_on in docker-compose

add depends_on to almost components

@Frapschen Frapschen requested a review from a team June 14, 2022 02:37
@Frapschen
Copy link
Contributor Author

#96

docker-compose.yml Outdated Show resolved Hide resolved
@Frapschen Frapschen requested a review from mic-max June 14, 2022 03:42
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

# Conflicts:
#	docker-compose.yml
@austinlparker
Copy link
Member

Please resolve open comments and we can get this merged, thanks!

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit e78c7c2 into open-telemetry:main Jun 16, 2022
GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
* add depends_on to almost components

* Update docker-compose.yml
@Frapschen Frapschen deleted the Add_depends_on branch August 4, 2022 08:22
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add depends_on to almost components

* Update docker-compose.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants