Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Implement temporality preference option #10796

Conversation

pirgeo
Copy link
Member

@pirgeo pirgeo commented Aug 2, 2024

Description

adds temporality preference option for internal telemetry exported via OTLP

Link to tracking issue

(partly) fixes #10745

Testing

unit tests

Documentation

Feature is already documented, but not implemented yet.

@pirgeo pirgeo requested review from a team and codeboten August 2, 2024 15:50
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.63%. Comparing base (88adaef) to head (56431ed).
Report is 5 commits behind head on main.

Files Patch % Lines
service/internal/proctelemetry/config.go 52.63% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10796      +/-   ##
==========================================
- Coverage   91.71%   91.63%   -0.08%     
==========================================
  Files         406      406              
  Lines       18947    18988      +41     
==========================================
+ Hits        17377    17400      +23     
- Misses       1211     1228      +17     
- Partials      359      360       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pirgeo pirgeo changed the title add temporality preference option [config] Implement temporality preference option Aug 2, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pirgeo

@codeboten codeboten merged commit 41fa6ff into open-telemetry:main Aug 6, 2024
49 of 50 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TemporalityPreference / DefaultHistogramAggregation are ignored
2 participants