Revert "[chore] use mdatagen to generate service metrics (#10160)" #10271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try#10160)" This reverts commit 10bcef3.
TylerHelmuth
approved these changes
May 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10271 +/- ##
==========================================
- Coverage 92.50% 92.49% -0.02%
==========================================
Files 388 387 -1
Lines 18288 18259 -29
==========================================
- Hits 16917 16888 -29
Misses 1025 1025
Partials 346 346 ☔ View full report in Codecov by Sentry. |
codeboten
deleted the
codeboten/revert-10bcef33e6d26104036ed2874cb179c4437abc98
branch
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 30, 2024
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 30, 2024
This reverts the reverts open-telemetry#10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check. Signed-off-by: Alex Boten <[email protected]>
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 30, 2024
This reverts the reverts open-telemetry#10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check. Signed-off-by: Alex Boten <[email protected]>
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jun 7, 2024
This reverts the reverts open-telemetry#10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check. Signed-off-by: Alex Boten <[email protected]>
codeboten
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts the reverts #10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check. Signed-off-by: Alex Boten <[email protected]>
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
…try#10160)" (open-telemetry#10271) This reverts commit 10bcef3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 10bcef3.