chore: fix update to golang-lru/v2 #35824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mechanical update did not work, apply changes to use type params.
github-actions
bot
requested review from
Frapschen,
portertech and
rmfitzpatrick
songy23
approved these changes
Oct 16, 2024
renovate
bot
deleted the branch
open-telemetry:renovate/github.conef.uk-hashicorp-golang-lru-2.x
|
Thanks Renovate! :/ |
codeboten
added a commit
that referenced
this pull request
Oct 18, 2024
#### Description Fixes incomplete mechanical update in #30890. The new version of golang-lru uses type params. Recreates #35824, which Renovate kindly closed without merging 🥲 #### Link to tracking issue Supersedes #30890 #### Testing Ran the unit tests. #### Documentation N/A Co-authored-by: Alex Boten <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description Fixes incomplete mechanical update in open-telemetry#30890. The new version of golang-lru uses type params. Recreates open-telemetry#35824, which Renovate kindly closed without merging 🥲 #### Link to tracking issue Supersedes open-telemetry#30890 #### Testing Ran the unit tests. #### Documentation N/A Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes incomplete mechanical update in #30890. The new version of golang-lru uses type params.
Link to tracking issue
Supersedes #30890
Testing
Ran the unit tests.
Documentation
N/A