Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prom translation fix metric comparison func #35763

Conversation

jmichalek132
Copy link
Contributor

Description

Link to tracking issue #35741

Fixes
Wrong comparison func implement in translator/prometheusremotewrite.

Testing

Documentation

@jmichalek132 jmichalek132 marked this pull request as ready for review October 13, 2024 21:07
@jmichalek132 jmichalek132 requested a review from a team as a code owner October 13, 2024 21:07
@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Oct 14, 2024
@andrzej-stencel andrzej-stencel merged commit 686721c into open-telemetry:main Oct 16, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 16, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue open-telemetry#35741
Fixes 
Wrong comparison func implement in translator/prometheusremotewrite.

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

Signed-off-by: Juraj Michalek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/translator/prometheus ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants