[receiver/prometheusremotewrite] Add HTTP server to handler PRW requests #35535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Questions:
receivers:
prometheusremotewrite:
exporters:
debug:
verbosity: detailed
service:
pipelines:
metrics:
receivers: [prometheusremotewrite]
exporters: [debug]After running it I'm getting this error: I had the impression that after merging the new component I could build the collector with it already. Do I need to do something else to be able to test this receiver? |
|
You can temporarily add it to here while you are testing: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/otelcontribcol/components.go. But just don't push That is part of the "Last PR" in the process of adding new components (https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components) |
dashpole
reviewed
Oct 2, 2024
|
And Yes, please add changelogs for each PR. |
ArthurSens
changed the title
ArthurSens
force-pushed
the
prw-receiver-httpserver
branch
from
fff855a to
5a8d1f2
Compare
|
Alrighty, I'm happy with the results so far
Content negotiation and very basic functionality will be done in follow up PRs :) |
dashpole
reviewed
Oct 2, 2024
ArthurSens
force-pushed
the
prw-receiver-httpserver
branch
from
5a8d1f2 to
5b0f81e
Compare
dashpole
approved these changes
Oct 2, 2024
dashpole
added
the
ready to merge
This was referenced Oct 2, 2024
ArthurSens
force-pushed
the
prw-receiver-httpserver
branch
from
5b0f81e to
6c1cfd4
Compare
Signed-off-by: Arthur Silva Sens <[email protected]>
ArthurSens
force-pushed
the
prw-receiver-httpserver
branch
from
6c1cfd4 to
7b5d4d9
Compare
jpkrohling
changed the title
ghost
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
…sts (open-telemetry#35535) Part of open-telemetry#33782 **Description:** This PR adds an HTTP server to the `prometheusremotewritereceiver` component. To keep PRs small for easier reviews, the handler doesn't do anything at the moment. Signed-off-by: Arthur Silva Sens <[email protected]>
andrzej-stencel
pushed a commit
that referenced
this pull request
Oct 30, 2024
**Description:** This PR builds on top of #35535, adding Content-Type negotiation for Remote-Write requests (still doesn't handle the data). Signed-off-by: Arthur Silva Sens <[email protected]>
bogdandrutu
pushed a commit
that referenced
this pull request
Nov 2, 2024
…35624) #### Description This PR builds on top of #35535 and #35565. We're now making sure we're able to unmarshal a remote write request, while also exercising the decompression that is made by OTel's confighttp. Signed-off-by: Arthur Silva Sens <[email protected]>
ArthurSens
added a commit
to ArthurSens/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
…pen-telemetry#35624) This PR builds on top of open-telemetry#35535 and open-telemetry#35565. We're now making sure we're able to unmarshal a remote write request, while also exercising the decompression that is made by OTel's confighttp. Signed-off-by: Arthur Silva Sens <[email protected]>
zzhlogin
pushed a commit
to zzhlogin/opentelemetry-collector-contrib-aws
that referenced
this pull request
Nov 12, 2024
…emetry#35565) **Description:** This PR builds on top of open-telemetry#35535, adding Content-Type negotiation for Remote-Write requests (still doesn't handle the data). Signed-off-by: Arthur Silva Sens <[email protected]>
MovieStoreGuy
pushed a commit
that referenced
this pull request
Dec 15, 2024
#### Description This PR builds on top of #35535, #35565 and #35624. Here we're parsing labels into resource/metric attributes. It's still not great because resource attributes (with exception to `service.namespace`, `service.name` and `service.name.id`) are encoded into a special metric called `target_info`. Metrics related to specific target infos may arrive in separate write requests, so it may be impossible to build the full OTLP metric in a stateless way. In this PR I'm ignoring this problem 😛, and transforming `job` and `instance` labels into resource attributes, while all other labels become scope attributes. Please focus on the latest commit when reviewing this PR :) 1c9ff80 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…emetry#35565) **Description:** This PR builds on top of open-telemetry#35535, adding Content-Type negotiation for Remote-Write requests (still doesn't handle the data). Signed-off-by: Arthur Silva Sens <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…pen-telemetry#35624) #### Description This PR builds on top of open-telemetry#35535 and open-telemetry#35565. We're now making sure we're able to unmarshal a remote write request, while also exercising the decompression that is made by OTel's confighttp. Signed-off-by: Arthur Silva Sens <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description This PR builds on top of open-telemetry#35535, open-telemetry#35565 and open-telemetry#35624. Here we're parsing labels into resource/metric attributes. It's still not great because resource attributes (with exception to `service.namespace`, `service.name` and `service.name.id`) are encoded into a special metric called `target_info`. Metrics related to specific target infos may arrive in separate write requests, so it may be impossible to build the full OTLP metric in a stateless way. In this PR I'm ignoring this problem 😛, and transforming `job` and `instance` labels into resource attributes, while all other labels become scope attributes. Please focus on the latest commit when reviewing this PR :) 1c9ff80 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
#### Description This PR builds on top of open-telemetry#35535, open-telemetry#35565 and open-telemetry#35624. Here we're parsing labels into resource/metric attributes. It's still not great because resource attributes (with exception to `service.namespace`, `service.name` and `service.name.id`) are encoded into a special metric called `target_info`. Metrics related to specific target infos may arrive in separate write requests, so it may be impossible to build the full OTLP metric in a stateless way. In this PR I'm ignoring this problem 😛, and transforming `job` and `instance` labels into resource attributes, while all other labels become scope attributes. Please focus on the latest commit when reviewing this PR :) 1c9ff80 --------- Signed-off-by: Arthur Silva Sens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #33782
Description:
This PR adds an HTTP server to the
prometheusremotewritereceivercomponent. To keep PRs small for easier reviews, the handler doesn't do anything at the moment.