[processor/groupbytrace] Update metric units #34167
Conversation
This updates units for groupbytraceprocessor internal telemetry.
| @@ -6,66 +6,66 @@ | |||
|
|
|||
| The following telemetry is emitted by this component. | |||
|
|
|||
| ### otelcol_processor_groupbytrace_conf_num_traces | |||
| ### processor_groupbytrace_conf_num_traces | |||
There was a problem hiding this comment.
do you know what happened here?
There was a problem hiding this comment.
I ran go generate ./... and it was updated automatically. I ran this to make sure documentation is up to date with metadata.yaml
There was a problem hiding this comment.
@codeboten, do you know if this is concerning?
|
I believe this should have a changelog |
|
I agree: there should be a changelog for the unit change, and there should not be a change in the metric name. I know @codeboten worked on adding the "otel_" prefix automatically and I think it would reflect in the documentation at the individual components, so this prefix change on this PR looks strange. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
There was a problem hiding this comment.
I think the unit updates look good. As @jpkrohling mentioned, a changelog entry for this would be great. I'm not seeing the prefix change mentioned, has that been addressed?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fix for processor/groupbytraceprocessor component
processor/groupbytraceprocessorLink to tracking Issue: #34143