Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][pkg/stanza] Use mock timers for flaky windows flash tests #34128

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

ChrsMark
Copy link
Member

Description:

Trying out to mock the actual clock in order to fix flaky tests on windows.
ref: #32715 (comment)

Link to tracking Issue: #32715

Testing:

Documentation:

@ChrsMark
Copy link
Member Author

/label "Run Windows"

@ChrsMark
Copy link
Member Author

ChrsMark commented Jul 17, 2024

Thank's @mx-psi for adding the label. Does the comment approach mentioned at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.105.0/CONTRIBUTING.md?plain=1#L374 work?

Edit: Ah it should only work for a specific set of labels 🤔

@mx-psi
Copy link
Member

mx-psi commented Jul 17, 2024

Yes, but 'Run Windows' is not one of the supported labels

@ChrsMark ChrsMark force-pushed the fix_stanza_timers branch 3 times, most recently from e2421fb to ee37ac3 Compare July 17, 2024 12:59
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jul 17, 2024
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark force-pushed the fix_stanza_timers branch from 862f557 to 263fb27 Compare July 18, 2024 07:40
@ChrsMark ChrsMark marked this pull request as ready for review July 18, 2024 11:38
@ChrsMark ChrsMark requested a review from a team July 18, 2024 11:38
@ChrsMark ChrsMark force-pushed the fix_stanza_timers branch from f3ac5c4 to 15e8ff0 Compare July 18, 2024 17:05
@ChrsMark ChrsMark force-pushed the fix_stanza_timers branch from 15e8ff0 to bbe3ad1 Compare July 18, 2024 17:13
@djaglowski djaglowski merged commit d865b6e into open-telemetry:main Jul 18, 2024
170 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 18, 2024
djaglowski pushed a commit that referenced this pull request Jul 23, 2024
…anFilter (#34174)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Similar to
#34128.
Mocking the time functions to fix flakiness on windows.

**Link to tracking Issue:** <Issue number if applicable>
#32838

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Signed-off-by: ChrsMark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants