-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][pkg/stanza] Use mock timers for flaky windows flash tests #34128
Merged
+48
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/label "Run Windows" |
ChrsMark
force-pushed
the
fix_stanza_timers
branch
from
July 17, 2024 09:02
015c3f2
to
78482ad
Compare
github-actions
bot
added
cmd/oteltestbedcol
connector/datadog
exporter/datadog
Datadog components
labels
Jul 17, 2024
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
liustanley,
mackjmr,
mx-psi and
songy23
July 17, 2024 09:11
Thank's @mx-psi for adding the label. Does the comment approach mentioned at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.105.0/CONTRIBUTING.md?plain=1#L374 work? Edit: Ah it should only work for a specific set of labels 🤔 |
Yes, but 'Run Windows' is not one of the supported labels |
ChrsMark
force-pushed
the
fix_stanza_timers
branch
3 times, most recently
from
July 17, 2024 12:59
e2421fb
to
ee37ac3
Compare
djaglowski
reviewed
Jul 17, 2024
djaglowski
reviewed
Jul 17, 2024
djaglowski
reviewed
Jul 17, 2024
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
fix_stanza_timers
branch
from
July 18, 2024 07:40
862f557
to
263fb27
Compare
ChrsMark
force-pushed
the
fix_stanza_timers
branch
from
July 18, 2024 17:05
f3ac5c4
to
15e8ff0
Compare
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
fix_stanza_timers
branch
from
July 18, 2024 17:13
15e8ff0
to
bbe3ad1
Compare
djaglowski
approved these changes
Jul 18, 2024
This was referenced Jul 19, 2024
djaglowski
pushed a commit
that referenced
this pull request
Jul 23, 2024
…anFilter (#34174) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Similar to #34128. Mocking the time functions to fix flakiness on windows. **Link to tracking Issue:** <Issue number if applicable> #32838 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Signed-off-by: ChrsMark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/otelcontribcol
otelcontribcol command
cmd/oteltestbedcol
connector/datadog
exporter/datadog
Datadog components
pkg/stanza
receiver/filelog
receiver/otlpjsonfile
Run Windows
Enable running windows test on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Trying out to mock the actual clock in order to fix flaky tests on windows.
ref: #32715 (comment)
Link to tracking Issue: #32715
Testing:
Documentation: