[pkg/ottl] Add Sprintf OTTL Converter
#33589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkingpoint
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
sinkingpoint
force-pushed
the
sinkingpoint/sprintf_func
branch
from
848b010 to
bab07fe
Compare
sinkingpoint
force-pushed
the
sinkingpoint/sprintf_func
branch
from
bab07fe to
0b2681e
Compare
evan-bradley
reviewed
Jul 1, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
sinkingpoint
force-pushed
the
sinkingpoint/sprintf_func
branch
from
0b2681e to
96f8328
Compare
This adds in a converter that calls `fmt.Sprintf` with a format string and a set of arguments. Signed-off-by: sinkingpoint <[email protected]>
sinkingpoint
force-pushed
the
sinkingpoint/sprintf_func
branch
from
96f8328 to
a848207
Compare
|
Apologies for the delay here. I think this should be good to go now? |
evan-bradley
approved these changes
Jul 25, 2024
TylerHelmuth
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds in a converter that calls
fmt.Sprintfwith a format string and a set of arguments.Link to tracking Issue: #33405
Testing: Added in a couple of unit tests
Documentation: Added the new converter to the functions readme