-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coralogix processor first PR #33458
Coralogix processor first PR #33458
Conversation
|
This PR should have a changelog entry. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I've left a lot of comments on the README, the goal is to be able to flesh out UI/UX up front, before getting too far into the implementation weeds.
There are also a number of CI/CD failures caused by this PR, so please take a look and resolve when you're able. Let me know if you run into any issues there, happy to help!
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Hey @crobert-1, thanks for the review! Thanks for the help 😄 |
Co-authored-by: Curtis Robert <[email protected]>
…to coralogix-proccesor-first-pr # Conflicts: # processor/coralogixprocessor/README.md
@crobert-1 can you please help me understand why I don't pass the CI? |
Co-authored-by: Curtis Robert <[email protected]>
You'll have to look through the different failed actions individually to see why they're failing. From what I can tell they're related to this PR. One example:
This means these files don't have the proper license header. If you look in For this failure:
The command There are more failures that need investigated, but let me know if there's anything you don't understand 👍 |
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
@atoulme I see I need your approval as well for the code owners 😄 |
Looks like there are some more check failures:
There may be more than that, I didn't check thoroughly. |
@@ -165,6 +165,7 @@ pkg/winperfcounters/ @open-teleme | |||
|
|||
processor/attributesprocessor/ @open-telemetry/collector-contrib-approvers @boostchicken | |||
processor/cumulativetodeltaprocessor/ @open-telemetry/collector-contrib-approvers @TylerHelmuth | |||
processor/coralogixprocessor/ @open-telemetry/collector-contrib-approvers @galrose @crobert-1 @eyalatz @roycald245 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke a CI in mainline: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10317079346/job/28560709557#step:16:11
codeowners are not members: eyalatz, roycald245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we fix this? Is this because we are missing in cmd/githubgen/allowlist.txt
?
**Description:** <Describe what has changed.> Adding a feature - Adding a feature to create templates (blueprints) from sql queries. Currently specifically for postgresql and mysql queries. **Link to tracking Issue:** open-telemetry#33090 **Testing:** <Describe what testing was performed and which tests were added.> currently no tests, will be added in next PR **Documentation:** <Describe the documentation added.> Added documentation for possible configuration and the usecase of the processor --------- Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Antoine Toulme <[email protected]>
Description:
Adding a feature - Adding a feature to create templates (blueprints) from sql queries.
Currently specifically for postgresql and mysql queries.
Link to tracking Issue: #33090
Testing:
currently no tests, will be added in next PR
Documentation:
Added documentation for possible configuration and the usecase of the processor