[chore][receiver/googlecloudspannerreceiver] Enable goleak checks #32307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
reviewed
Apr 11, 2024
|
Please rebase |
crobert-1
force-pushed
the
goleak_googlespanrec_internal
branch
from
6bebe9b to
81ea789
Compare
songy23
approved these changes
Apr 11, 2024
codeboten
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a test only change that enables
goleakchecks on some of the internal packages of the Google Cloud Spanner receiver to help ensure no goroutines are leaking. Some tests were missing shutdown calls so those have been added.Link to tracking Issue:
#30438
Testing:
All existing tests are passing, as well as added
goleakchecks.