-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/apachedruidreceiver] Add Apache Druid receiver #31804
Conversation
df1af00
to
f17eeed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add the goleak check for this package? There's a description here on what to do.
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
confighttp.HTTPServerSettings was just renamed confighttp.ServerConfig, please rebase to latest main and change in your code. |
Co-authored-by: Antoine Toulme <[email protected]>
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@yuanlihan please add a changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really sorry about the redirection here, but this file is actually now generated. You can delete this file and then run make generate
, and a new file generated_package_test.go
will be added instead 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I'll update them.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
still waiting on changelog? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description: The first PR of Apache Druid Receiver as described in issue #29685
Link to tracking Issue: #29685
Testing: This part will be detailed in follow implementation PR.
Documentation: See initial README.