Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] move opensearch exporter to generated lifecycle tests #30476

Merged
merged 8 commits into from
Jan 17, 2024
Merged

[chore] move opensearch exporter to generated lifecycle tests #30476

merged 8 commits into from
Jan 17, 2024

Conversation

JaredTan95
Copy link
Member

Relates to #27849

@JaredTan95 JaredTan95 requested a review from Aneurysm9 as a code owner January 12, 2024 11:30
@JaredTan95 JaredTan95 requested a review from a team January 12, 2024 11:30
@JaredTan95 JaredTan95 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2024
codeboten
codeboten requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the lifecycle tests are failing:


            	            	Permanent error: Permanent error: flush: dial tcp: lookup opensearch.example.com on 127.0.0.53:53: no such host
            	            	Permanent error: Permanent error: flush: dial tcp: lookup opensearch.example.com on 127.0.0.53:53: no such host

@JaredTan95
Copy link
Member Author

JaredTan95 commented Jan 13, 2024 •
edited
Loading

Looks like the lifecycle tests are failing:


            	            	Permanent error: Permanent error: flush: dial tcp: lookup opensearch.example.com on 127.0.0.53:53: no such host
            	            	Permanent error: Permanent error: flush: dial tcp: lookup opensearch.example.com on 127.0.0.53:53: no such host

The opensearch exporter endpoint in config mus not be empty and requires an address to receive the consumed traces data, so we'll skip the error checking by expect_consumer_error: true for now

@codeboten codeboten merged commit 206e1a8 into open-telemetry:main Jan 17, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 17, 2024
@JaredTan95 JaredTan95 deleted the opensearchexporter_life branch January 18, 2024 01:06
mfyuce pushed a commit to mfyuce/opentelemetry-collector-contrib that referenced this pull request Jan 18, 2024
@JaredTan95 @mfyuce
[chore] move opensearch exporter to generated lifecycle tests (open-t…
77cf682 
…elemetry#30476)

Relates to
open-telemetry#27849

---------

Signed-off-by: Jared Tan <[email protected]>
@atoulme atoulme mentioned this pull request Jan 31, 2024
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@JaredTan95 @cparkins
[chore] move opensearch exporter to generated lifecycle tests (open-t…
35d3f23 
…elemetry#30476)

Relates to
open-telemetry#27849

---------

Signed-off-by: Jared Tan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@codeboten codeboten

Labels
exporter/opensearch Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.93.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JaredTan95 @codeboten