Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]Add status header for simpleprometheus #11091

Merged
merged 1 commit into from
Jun 17, 2022
Merged

[docs]Add status header for simpleprometheus #11091

merged 1 commit into from
Jun 17, 2022

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jun 17, 2022 •
edited
Loading

part of issue: #10116

Add status header for simpleprometheus

@my-git9 my-git9 requested review from a team and pmm-sumo June 17, 2022 00:14
@my-git9 my-git9 force-pushed the simpleprometheusreceiver branch from c24e9d9 to 26d1dbc Compare June 17, 2022 00:16
@mx-psi
Copy link
Member

mx-psi commented Jun 17, 2022

@my-git9 This does not fix #10116 (only part of it), could you edit your description so that that issue does not get closed when we merge this?

@my-git9
Copy link
Member Author

my-git9 commented Jun 17, 2022

@my-git9 This does not fix #10116 (only part of it), could you edit your description so that that issue does not get closed when we merge this?

Updated, can you see now

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 17, 2022
mx-psi
mx-psi approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (This component does not have a CODEOWNER)

@codeboten codeboten merged commit 1d1a755 into open-telemetry:main Jun 17, 2022
@codeboten codeboten mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@codeboten codeboten codeboten approved these changes

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

Assignees

@dashpole dashpole

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@my-git9 @mx-psi @codeboten @dashpole