Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/githubgen] Make checking OpenTelemetry membership optional #36263

Closed
atoulme opened this issue Nov 7, 2024 · 2 comments · Fixed by #36398
Closed

[cmd/githubgen] Make checking OpenTelemetry membership optional #36263

atoulme opened this issue Nov 7, 2024 · 2 comments · Fixed by #36398
Labels
cmd/githubgen Contribfest enhancement New feature or request

Comments

@atoulme
Copy link
Contributor

atoulme commented Nov 7, 2024 •
edited
Loading

Component(s)

cmd/githubgen

Is your feature request related to a problem? Please describe.

The cmd/githubgen check only runs on main right now as it requires access to a github token to check the contributors membership with the OpenTelemetry project.

Describe the solution you'd like

We could make the check with github optional so we can at least regenerate the CODEOWNERS file. This will deter manual changes to the CODEOWNERS file. We can then run githubgen on any PR.

Describe alternatives you've considered

No response

Additional context

No response
@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme added Contribfest and removed needs triage New item requiring triage labels Nov 8, 2024
@github-actions github-actions bot mentioned this issue Nov 12, 2024
Closed
@Aneurysm9
Copy link
Member

I'll try tackling this.

@Aneurysm9 Aneurysm9 mentioned this issue Nov 16, 2024
Merged
RutvikS-crest pushed a commit to RutvikS-crest/opentelemetry-collector-contrib that referenced this issue Dec 9, 2024
@Aneurysm9 @RutvikS-crest
[cmd/githubgen] Add a flag to skip GitHub organization membership che…
4f82d23 
…cks (open-telemetry#36398)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds a `--skipgithub` flag to allow generating the `CODEOWNERS` file
without requiring a PAT to verify membership in the OpenTelemetry GitHub
organization.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36263

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Executed command without providing a PAT and confirmed it did not
produce errors or unexpected changes to the `CODEOWNERS` file.

<!--Describe the documentation added.-->
#### Documentation

Updated `README`

<!--Please delete paragraphs that you did not use before submitting.-->

Signed-off-by: Anthony J Mirabella <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@Aneurysm9 @sbylica-splunk
[cmd/githubgen] Add a flag to skip GitHub organization membership che…
c3c6fd0 
…cks (open-telemetry#36398)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds a `--skipgithub` flag to allow generating the `CODEOWNERS` file
without requiring a PAT to verify membership in the OpenTelemetry GitHub
organization.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36263

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Executed command without providing a PAT and confirmed it did not
produce errors or unexpected changes to the `CODEOWNERS` file.

<!--Describe the documentation added.-->
#### Documentation

Updated `README`

<!--Please delete paragraphs that you did not use before submitting.-->

Signed-off-by: Anthony J Mirabella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd/githubgen Contribfest enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@atoulme @Aneurysm9