Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown-link-check with renovatebot #36259

Closed
mx-psi opened this issue Nov 7, 2024 · 2 comments · Fixed by #36552
Closed

Update markdown-link-check with renovatebot #36259

mx-psi opened this issue Nov 7, 2024 · 2 comments · Fixed by #36552
Assignees
Labels
ci-cd CI, CD, testing, build issues priority:p2 Medium release-retro Issues discussed in a release retrospective

Comments

@mx-psi
Copy link
Member

mx-psi commented Nov 7, 2024

Component(s)

No response

Describe the issue you're reporting

We should use renovatebot to update markdown-link-check over time similar to what we do with other dependencies.

@mx-psi mx-psi added priority:p2 Medium ci-cd CI, CD, testing, build issues release-retro Issues discussed in a release retrospective labels Nov 7, 2024
@mowies
Copy link
Member

mowies commented Nov 7, 2024

I can work on that

@mowies
Copy link
Member

mowies commented Nov 26, 2024

@mx-psi PR is done and ready for review :)

mx-psi pushed a commit that referenced this issue Nov 26, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds markdown-link-check to the tracked dependencies of
renovate. It achieves that by using the
[`customManagers:githubActionsVersions`](https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions)
renovate preset that enables user to update arbitrary versions in github
actions files without having to maintain their own regex for them.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes #36259

<!--Describe what testing was performed and which tests were added.-->
#### Testing
This setup is already in use in the dynatrace collector distro and works
great: [latest update
PR](Dynatrace/dynatrace-otel-collector#382),
[renovate
config](https://github.com/Dynatrace/dynatrace-otel-collector/blob/07e4662f92b0cadfb311eca74c9269c1c1598634/renovate.json#L6)

---------

Signed-off-by: Moritz Wiesinger <[email protected]>
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this issue Dec 5, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds markdown-link-check to the tracked dependencies of
renovate. It achieves that by using the
[`customManagers:githubActionsVersions`](https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions)
renovate preset that enables user to update arbitrary versions in github
actions files without having to maintain their own regex for them.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36259

<!--Describe what testing was performed and which tests were added.-->
#### Testing
This setup is already in use in the dynatrace collector distro and works
great: [latest update
PR](Dynatrace/dynatrace-otel-collector#382),
[renovate
config](https://github.com/Dynatrace/dynatrace-otel-collector/blob/07e4662f92b0cadfb311eca74c9269c1c1598634/renovate.json#L6)

---------

Signed-off-by: Moritz Wiesinger <[email protected]>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this issue Dec 6, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds markdown-link-check to the tracked dependencies of
renovate. It achieves that by using the
[`customManagers:githubActionsVersions`](https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions)
renovate preset that enables user to update arbitrary versions in github
actions files without having to maintain their own regex for them.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36259

<!--Describe what testing was performed and which tests were added.-->
#### Testing
This setup is already in use in the dynatrace collector distro and works
great: [latest update
PR](Dynatrace/dynatrace-otel-collector#382),
[renovate
config](https://github.com/Dynatrace/dynatrace-otel-collector/blob/07e4662f92b0cadfb311eca74c9269c1c1598634/renovate.json#L6)

---------

Signed-off-by: Moritz Wiesinger <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds markdown-link-check to the tracked dependencies of
renovate. It achieves that by using the
[`customManagers:githubActionsVersions`](https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions)
renovate preset that enables user to update arbitrary versions in github
actions files without having to maintain their own regex for them.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36259

<!--Describe what testing was performed and which tests were added.-->
#### Testing
This setup is already in use in the dynatrace collector distro and works
great: [latest update
PR](Dynatrace/dynatrace-otel-collector#382),
[renovate
config](https://github.com/Dynatrace/dynatrace-otel-collector/blob/07e4662f92b0cadfb311eca74c9269c1c1598634/renovate.json#L6)

---------

Signed-off-by: Moritz Wiesinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues priority:p2 Medium release-retro Issues discussed in a release retrospective
Projects
None yet
2 participants