-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker_observer]: Potential issue with image regex #36239
Labels
Comments
odvarkadaniel
added
bug
Something isn't working
needs triage
New item requiring triage
labels
Nov 6, 2024
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I reported a very similar issue for the |
This was referenced Dec 17, 2024
andrzej-stencel
pushed a commit
that referenced
this issue
Jan 7, 2025
#### Description Fix the regex used to match docker SHA256. #### Link to tracking issue Fix #36239 #### Testing Local run of `make` at `internal/docker` - caveat: if some other test code depending on this may fail if it is not using a SHA256 with exactly 64 chars it will be broken by this change. I will add any test fix for any such case detected via CI. #### Documentation N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
extension/observer/dockerobserver
What happened?
Description
We are seeing errors regaring image parsing in the
otelcol
binary.Steps to Reproduce
Have an image running on a node with the sha256 part not being only numbers, but e.g.
<repository>:<path>@sha256:07faaa0588009ace...
The regex expects the sha256 part to contain numbers only.
What are the reasons behind the sha256 digest regex part accepting only digits?
Expected Result
Not fail the config.image parsing.
Actual Result
Error as mentioned above.
Collector version
v0.103.0
Environment information
Environment
OS: Ubuntu 22.04.5 LTS
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: