Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[broken test] deltatocumulativeprocessor TestProcessor fails on Windows #35876

Closed
songy23 opened this issue Oct 18, 2024 · 4 comments · Fixed by #35902
Closed

[broken test] deltatocumulativeprocessor TestProcessor fails on Windows #35876

songy23 opened this issue Oct 18, 2024 · 4 comments · Fixed by #35902
Assignees
@ArthurSens
Labels
os:windows processor/deltatocumulative

Comments

@songy23
Copy link
Member

songy23 commented Oct 18, 2024

Component(s)

processor/deltatocumulative

Describe the issue you're reporting

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11406634691/job/31740841412


=== FAIL: . TestProcessor/tracking (0.00s)
    processor_test.go:63: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/processor_test.go:63
        	Error:      	Received unexpected error:
        	            	in: open in: file does not exist
        	Test:       	TestProcessor/tracking

=== FAIL: . TestProcessor (0.01s)

=== FAIL: . TestProcessor/limit (re-run 1) (0.00s)
    processor_test.go:63: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/processor_test.go:63
        	Error:      	Received unexpected error:
        	            	in: open in: file does not exist
        	Test:       	TestProcessor/limit

=== FAIL: . TestProcessor (re-run 1) (0.01s)

=== FAIL: . TestProcessor/notemporality-ignored (re-run 1) (0.00s)
    processor_test.go:63: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/processor_test.go:63
        	Error:      	Received unexpected error:
        	            	in: open in: file does not exist
        	Test:       	TestProcessor/notemporality-ignored

=== FAIL: . TestProcessor (re-run 1) (0.00s)

=== FAIL: . TestProcessor/timestamps (re-run 1) (0.00s)
    processor_test.go:63: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/processor_test.go:63
        	Error:      	Received unexpected error:
        	            	in: open in: file does not exist
        	Test:       	TestProcessor/timestamps

=== FAIL: . TestProcessor (re-run 1) (0.01s)

=== FAIL: . TestProcessor/tracking (re-run 1) (0.00s)
    processor_test.go:63: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/processor_test.go:63
        	Error:      	Received unexpected error:
        	            	in: open in: file does not exist
        	Test:       	TestProcessor/tracking

=== FAIL: . TestProcessor (re-run 1) (0.00s)
make[2]: *** [../../Makefile.Common:131: test] Error 1
make[1]: *** [Makefile:200: processor/deltatocumulativeprocessor] Error 2
make[1]: *** Waiting for unfinished jobs....
@songy23 songy23 added os:windows needs triage New item requiring triage labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@songy23 songy23 removed the needs triage New item requiring triage label Oct 21, 2024
@songy23
Copy link
Member Author

songy23 commented Oct 21, 2024

#35562 (comment) looks like @ArthurSens has been looking into this already

@ArthurSens ArthurSens mentioned this issue Oct 21, 2024
Merged
@ArthurSens
Copy link
Member

Hi @songy23, do you mind adding the label to trigger the windows tests in that PR? :)

@songy23
Copy link
Member Author

songy23 commented Oct 21, 2024

Sure

@github-actions github-actions bot mentioned this issue Oct 22, 2024
Closed
codeboten pushed a commit that referenced this issue Oct 23, 2024
@ArthurSens @sh0rez
[processor/deltatocumulative] - Fix tests on windows (#35902)
5431164 
#### Description
Our test format testar is based on golang.org/x/tools/txtar, which does
not properly handle CRLF line endings.

When using git on windows, git turns LF into CRLF, making our tests fail
on that platform.

The Go CL does not appears to be inactive, so I opted for replacing CRLF
with LF for now within testar.

#### Link to tracking issue
Fixes #35876

Co-authored-by: sh0rez <[email protected]>
@songy23 songy23 mentioned this issue Oct 23, 2024
Closed
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@ArthurSens @sh0rez @sbylica-splunk
[processor/deltatocumulative] - Fix tests on windows (open-telemetry#…
9b3a1f0 
…35902)

#### Description
Our test format testar is based on golang.org/x/tools/txtar, which does
not properly handle CRLF line endings.

When using git on windows, git turns LF into CRLF, making our tests fail
on that platform.

The Go CL does not appears to be inactive, so I opted for replacing CRLF
with LF for now within testar.

#### Link to tracking issue
Fixes open-telemetry#35876

Co-authored-by: sh0rez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurSens ArthurSens

Labels
os:windows processor/deltatocumulative
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[processor/deltatocumulative] - Fix tests on windows ArthurSens/opentelemetry-collector-contrib
2 participants
@songy23 @ArthurSens