Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/exceptionsconnector] the dimension configuration does not support the resource attributes context #34603

Closed
JaredTan95 opened this issue Aug 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working connector/exceptions

Comments

@JaredTan95
Copy link
Member

JaredTan95 commented Aug 12, 2024

Component(s)

connector/exceptions

What happened?

Description

Configure additional attribute in dimensions as described in the documentation, such as adding k8s.namespace.name, and find that the resulting metric or logs do not record k8s.namespace.name:

  exceptions/traces:
    dimensions:
      - name: k8s.namespace.name # 👈  add additional dimension that dons't in span or event attributes 
      - name: exception.type
      - name: exception.message
      - name: exception.stacktrace
      # span name
      - name: name

c.attrToLogRecord(sl, serviceName, span, event)

I think we need should pass a resource attribute, similar to spanmetricconnector

if v, ok := getDimensionValue(d, span.Attributes(), resourceAttrs); ok {

Collector version

main

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@JaredTan95 JaredTan95 added bug Something isn't working needs triage New item requiring triage labels Aug 12, 2024
@JaredTan95 JaredTan95 self-assigned this Aug 12, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Aug 12, 2024
mx-psi pushed a commit that referenced this issue Aug 13, 2024
…take effect for resource attributes (#34604)

**Description:** Fix dimensions configuration did not take effect for
resource attributes
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** #34603

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Signed-off-by: Jared Tan <[email protected]>
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
…take effect for resource attributes (open-telemetry#34604)

**Description:** Fix dimensions configuration did not take effect for
resource attributes
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** open-telemetry#34603

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Signed-off-by: Jared Tan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working connector/exceptions
Projects
None yet
Development

No branches or pull requests

2 participants