Use confighttp for target allocator http client
#31449
Assignees
Labels
Comments
swiatekm
added
enhancement
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
If this sounds reasonable, you can assign this issue to me. I basically already have this change implemented, it's very small. |
|
This seems reasonable to me. Is it breaking, or additive? |
|
Additive, the only common field is |
|
Sounds great. Feel free to open the PR. |
This was referenced Mar 5, 2024
TylerHelmuth
pushed a commit
that referenced
this issue
Mar 14, 2024
) **Description:** Use confighttp for target allocator http client in prometheus receiver. **Link to tracking Issue:** #31449 **Testing:** Added some simple config tests. **Documentation:** Added a note to the README.
|
#31452 is merged, can we close this issue? |
This was referenced Jul 11, 2024
andrzej-stencel
pushed a commit
that referenced
this issue
Aug 19, 2024
… clienthttp (#34035) **Description:** Translating relevant fields from TargetAllocator's confighttps to be used in the service discovery http client config This assures that the relevant config defiend for the TA is used by the service discovery jobs in addition to the scrape configs (as solved by #31449) **Link to tracking Issue:** Resolves #33370 **Testing:** Added unit tests. **Documentation:**
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this issue
Sep 12, 2024
… clienthttp (open-telemetry#34035) **Description:** Translating relevant fields from TargetAllocator's confighttps to be used in the service discovery http client config This assures that the relevant config defiend for the TA is used by the service discovery jobs in addition to the scrape configs (as solved by open-telemetry#31449) **Link to tracking Issue:** Resolves open-telemetry#33370 **Testing:** Added unit tests. **Documentation:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
receiver/prometheus
Is your feature request related to a problem? Please describe.
We'd like to use TLS client authentication for communication between the collector and target allocator. A detailed discussion about the reasons can be found here: open-telemetry/opentelemetry-operator#1669.
Describe the solution you'd like
We should use
go.opentelemetry.io/collector/config/confighttp. This is a standard for collector components and users should be comfortable with it. It will also give us a lot more customization for very little additional maintenance burden.Describe alternatives you've considered
We could implement just the TLS options ourselves, but there doesn't seem to be any upside to that.
Additional context
No response
The text was updated successfully, but these errors were encountered: