Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Googlecloud exporter transform recommendation breaks logging #27803

Closed
dashpole opened this issue Oct 17, 2023 · 1 comment · Fixed by #30929
Closed

Googlecloud exporter transform recommendation breaks logging #27803

dashpole opened this issue Oct 17, 2023 · 1 comment · Fixed by #30929
Assignees
@dashpole
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@dashpole
Copy link
Contributor

dashpole commented Oct 17, 2023 •
edited
Loading

Component(s)

exporter/googlecloud

What happened?

Description

This documentation is a bit misleading. If someone applies this documentation: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/googlecloudexporter/README.md#preventing-metric-label-collisions with a logging pipeline, it will not map to the correct logging monitored resource. We should make clear that the documentation does not apply to logging or trace, and that it should (probably) only be used with the prometheus receiver.
@dashpole dashpole added bug Something isn't working needs triage New item requiring triage labels Oct 17, 2023
@dashpole dashpole self-assigned this Oct 17, 2023
@dashpole dashpole added documentation Improvements or additions to documentation and removed needs triage New item requiring triage labels Oct 17, 2023
@github-actions github-actions bot mentioned this issue Oct 24, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Dec 18, 2023
@dashpole dashpole removed the Stale label Jan 8, 2024
@dashpole dashpole mentioned this issue Jan 31, 2024
Merged
djaglowski pushed a commit that referenced this issue Feb 1, 2024
@dashpole @crobert-1
Update gcp documentation (#30929)
0e28e15 
Fixes
#26649
Fixes
#27803

---------

Co-authored-by: Curtis Robert <[email protected]>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@dashpole @crobert-1 @cparkins
Update gcp documentation (open-telemetry#30929)
142c1e9 
Fixes
open-telemetry#26649
Fixes
open-telemetry#27803

---------

Co-authored-by: Curtis Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gcp documentation dashpole/opentelemetry-collector-contrib
1 participant
@dashpole