-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support BooleanAttributes in the telemetrygen tool #18928
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This would be pretty simple to implement, would you be willing to open a PR @petercline? To do this we would need to:
|
I already have an implementation of this locally @mx-psi and would be happy to open a PR. My implementation differs slightly from what you suggest above. I need to go through the approval process with my employer but that is relatively quick. I should be able to post the PR later this week. Thanks! |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@petercline any updates on this? |
Sorry, I still plan to tackle this, it has just been sidetracked by other
priorities. I will get to it before the end of this month.
…On Mon, Jul 3, 2023 at 4:57 AM Pablo Baeyens ***@***.***> wrote:
@petercline <https://github.com/petercline> any updates on this?
—
Reply to this email directly, view it on GitHub
<#18928 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADAAV5JKTWR4AXXPNRHQPLXOKCP5ANCNFSM6AAAAAAVJWYTFI>
.
You are receiving this because you were mentioned.Message ID:
<open-telemetry/opentelemetry-collector-contrib/issues/18928/1617665815@
github.com>
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
…ry#34558) **Description:** Support boolean values in attributes **Link to tracking Issue:** Resolves open-telemetry#18928 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Murphy Chen <[email protected]>
Component(s)
cmd/telemetrygen
Is your feature request related to a problem? Please describe.
Support was just merged for a BooleanAttribute PolicyType for tail sampling (#18764). The telemetrygen tool should be able to generate traces with boolean attributes to facilitate testing and development of tail sampling policies that leverage this new PolicyType
Describe the solution you'd like
In writing the referenced PR above, I made these changes locally. The basic idea is to introduce a new struct type clled OtlpAttributes that includes two maps, one for string attributes and another for boolean. this could be extended in the future to support numeric attributes as well. The same --otlp-attribute flag is supported for backwards compatibility but now values that aren't quoted will be treated as boolean values if they are true or false, and as errors like previously otherwise
Describe alternatives you've considered
We could support different flags for attributes of differing types.
Additional context
No response
The text was updated successfully, but these errors were encountered: