Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BooleanAttributes in the telemetrygen tool #18928

Closed
petercline opened this issue Feb 27, 2023 · 9 comments · Fixed by #34558
Closed

Support BooleanAttributes in the telemetrygen tool #18928

petercline opened this issue Feb 27, 2023 · 9 comments · Fixed by #34558
Assignees
Labels
cmd/telemetrygen telemetrygen command enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium

Comments

@petercline
Copy link
Contributor

Component(s)

cmd/telemetrygen

Is your feature request related to a problem? Please describe.

Support was just merged for a BooleanAttribute PolicyType for tail sampling (#18764). The telemetrygen tool should be able to generate traces with boolean attributes to facilitate testing and development of tail sampling policies that leverage this new PolicyType

Describe the solution you'd like

In writing the referenced PR above, I made these changes locally. The basic idea is to introduce a new struct type clled OtlpAttributes that includes two maps, one for string attributes and another for boolean. this could be extended in the future to support numeric attributes as well. The same --otlp-attribute flag is supported for backwards compatibility but now values that aren't quoted will be treated as boolean values if they are true or false, and as errors like previously otherwise

Describe alternatives you've considered

We could support different flags for attributes of differing types.

Additional context

No response

@petercline petercline added enhancement New feature or request needs triage New item requiring triage labels Feb 27, 2023
@petercline petercline changed the title Support BooleanAttributes in the telemtrygen tool Support BooleanAttributes in the telemetrygen tool Feb 27, 2023
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Feb 27, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi
Copy link
Member

mx-psi commented Feb 27, 2023

This would be pretty simple to implement, would you be willing to open a PR @petercline?

To do this we would need to:

@mx-psi mx-psi added priority:p2 Medium and removed needs triage New item requiring triage labels Feb 27, 2023
@petercline
Copy link
Contributor Author

I already have an implementation of this locally @mx-psi and would be happy to open a PR. My implementation differs slightly from what you suggest above. I need to go through the approval process with my employer but that is relatively quick. I should be able to post the PR later this week. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 1, 2023
@mx-psi mx-psi removed the Stale label May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 3, 2023
@mx-psi
Copy link
Member

mx-psi commented Jul 3, 2023

@petercline any updates on this?

@petercline
Copy link
Contributor Author

petercline commented Jul 3, 2023 via email

@mx-psi mx-psi removed the Stale label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 4, 2023
@mx-psi mx-psi removed the Stale label Sep 4, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 6, 2023
@mx-psi mx-psi added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Nov 6, 2023
@mx-psi mx-psi closed this as completed in 148f5e3 Aug 9, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
…ry#34558)

**Description:** Support boolean values in attributes


**Link to tracking Issue:** Resolves
open-telemetry#18928

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: Murphy Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants