prometheusremotewrite: wal default nop-logger

Initializes the WAL with a default nop logger, instead of previous nil which led to panics.
open-telemetry · Jun 5, 2023 · 9dedddd · 9dedddd
1 parent 45fa20d
commit 9dedddd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/exporter/prometheusremotewriteexporter/wal.go b/exporter/prometheusremotewriteexporter/wal.go
@@ -86,6 +86,7 @@ func newWAL(walConfig *WALConfig, exportSink func(context.Context, []*prompb.Wri
 		rNotify:    make(chan struct{}),
 		rWALIndex:  &atomic.Uint64{},
 		wWALIndex:  &atomic.Uint64{},
+		log:        zap.NewNop(),
 	}
 
 	return &wal, nil

diff --git a/exporter/prometheusremotewriteexporter/wal_test.go b/exporter/prometheusremotewriteexporter/wal_test.go
@@ -114,6 +114,7 @@ func TestWAL_persist(t *testing.T) {
 
 	pwal, err := newWAL(config, doNothingExportSink)
 	require.Nil(t, err)
+	pwal.log = zap.Must(zap.NewDevelopment())
 
 	// 1. Write out all the entries.
 	reqL := []*prompb.WriteRequest{