Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Parrots extension for op PrRoI #2280

Merged
merged 11 commits into from
Oct 11, 2022

Conversation

CokeDong
Copy link
Contributor

Support Parrots extension for op PrRoI

@CokeDong CokeDong marked this pull request as draft September 22, 2022 10:42
@CokeDong CokeDong force-pushed the parrots_support_PrRoIPool branch 2 times, most recently from dee696b to c9da13a Compare September 23, 2022 08:12
@CokeDong CokeDong marked this pull request as ready for review September 26, 2022 09:17
@CokeDong CokeDong force-pushed the parrots_support_PrRoIPool branch from 1b9a301 to 95128f9 Compare September 27, 2022 06:03
@zhouzaida zhouzaida requested a review from grimoire September 28, 2022 02:33
mmcv/ops/prroi_pool.py Outdated Show resolved Hide resolved
mmcv/ops/prroi_pool.py Outdated Show resolved Hide resolved
mmcv/ops/prroi_pool.py Outdated Show resolved Hide resolved
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CokeDong CokeDong requested a review from zhouzaida September 30, 2022 08:35
mmcv/ops/prroi_pool.py Outdated Show resolved Hide resolved
@CokeDong CokeDong requested a review from zhouzaida October 10, 2022 06:27
@CokeDong CokeDong force-pushed the parrots_support_PrRoIPool branch from 0847982 to 207c331 Compare October 10, 2022 07:13
@zhouzaida zhouzaida merged commit dd5b415 into open-mmlab:master Oct 11, 2022
cathyzhang222 pushed a commit to cathyzhang222/mmcv that referenced this pull request Oct 20, 2022
* Support parrots extension for op PrRoI

* Fix lint

* Fix cpp lint

* Fix testcase failure by false requires_grad in self-defined autograd Funtion

* Fix issues

* Fix flake8

* Fix isort

* Adaption for typechecking for PrRoIPoolFunction

* Fix lint

* Support only float32

* bugfix
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Oct 20, 2022
* Support parrots extension for op PrRoI

* Fix lint

* Fix cpp lint

* Fix testcase failure by false requires_grad in self-defined autograd Funtion

* Fix issues

* Fix flake8

* Fix isort

* Adaption for typechecking for PrRoIPoolFunction

* Fix lint

* Support only float32

* bugfix
cathyzhang222 pushed a commit to cathyzhang222/mmcv that referenced this pull request Oct 20, 2022
* Support parrots extension for op PrRoI

* Fix lint

* Fix cpp lint

* Fix testcase failure by false requires_grad in self-defined autograd Funtion

* Fix issues

* Fix flake8

* Fix isort

* Adaption for typechecking for PrRoIPoolFunction

* Fix lint

* Support only float32

* bugfix
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Oct 22, 2022
* Support parrots extension for op PrRoI

* Fix lint

* Fix cpp lint

* Fix testcase failure by false requires_grad in self-defined autograd Funtion

* Fix issues

* Fix flake8

* Fix isort

* Adaption for typechecking for PrRoIPoolFunction

* Fix lint

* Support only float32

* bugfix
zhouzaida pushed a commit that referenced this pull request Oct 22, 2022
* Support parrots extension for op PrRoI

* Fix lint

* Fix cpp lint

* Fix testcase failure by false requires_grad in self-defined autograd Funtion

* Fix issues

* Fix flake8

* Fix isort

* Adaption for typechecking for PrRoIPoolFunction

* Fix lint

* Support only float32

* bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants