Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make RPC endpoint configurable for wallet provider #16

Merged
merged 2 commits into from
Dec 29, 2024
Merged

feat: make RPC endpoint configurable for wallet provider #16

merged 2 commits into from
Dec 29, 2024

Conversation

tfrg
Copy link
Contributor

@tfrg tfrg commented Dec 29, 2024

What type of PR is this?

  • feature

What this PR does:

  • Make RPC endpoint configurable in GnoWalletProvider to support dynamic RPC URLs

Changes:

  • Add RPC parameter to connect and connectProvider methods
  • Initialize RPC field with null value in constructor
  • Import and utilize DEFAULT_RPC_URL as fallback option
  • Replace hardcoded RPC URL with configurable parameter

jinoosss
jinoosss reviewed Dec 29, 2024
View reviewed changes
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix.
Please check out some of the comments.

packages/sdk/src/core/constants/chains.constant.ts Outdated Show resolved Hide resolved
packages/sdk/src/providers/gno-wallet/gno-wallet.ts Outdated Show resolved Hide resolved
@tfrg tfrg force-pushed the feat/dynamic-rpc-config branch from 94c0099 to 6444fa2 Compare December 29, 2024 12:14
jinoosss
jinoosss approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jinoosss jinoosss merged commit 38684a6 into onbloc:main Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinoosss jinoosss jinoosss approved these changes

Assignees

@tfrg tfrg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfrg @jinoosss