Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump [email protected], structured build configuration with convensions plugin, and fix deprecated methods #1237

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Dec 28, 2024

OmegaT has already had 42 module subproject and there is huge complexity in build.gradle script, which is > 1800 lines-of-code. Conventions plugin is a Grade recommended way to share build configurations.

Pull request type

  • Build and release changes -> [build/release]

What does this PR change?

  • Change Gradle version to latest 8.12
  • Conventions plugin help us to share build configurations among modules.
  • Update deprecated Gradle command with another recommended directives

Other information

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@miurahr miurahr marked this pull request as draft December 29, 2024 01:55

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@miurahr miurahr marked this pull request as ready for review December 29, 2024 11:49
- set updateDaeonJvm.jvmVersion with JavaLanguageVersion object

Signed-off-by: Hiroshi Miura <[email protected]>
- Use indirect task reference for caching
- Space-assignment syntax in Groovy DSL has been deprecated
- Replace deprecated exec to injected operations
- Introduce build-logic convention plugin
    - Move gradle/utils.gradle definitions to convention plugin
    - Move allProjects{} definition to convention plugin
    - Jaxb tasks as a convention plugin
    - Move doc related to document-conventions plugin
    - Move jpackage related to jpkg-conventions.gradle
    - Move launch4j configurations into windows-conventions.gradle
- Migrate modules to use org.omegat.java-conventions plugin

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr force-pushed the topic/miurahr/build-system/update-deprecated-gradle-method branch from bebf681 to 9ea116d Compare December 29, 2024 11:58
Signed-off-by: Hiroshi Miura <[email protected]>
- move ben-manes.versions plugin deleared in version-conventions
- improve test and JavaCompile common configurations

Signed-off-by: Hiroshi Miura <[email protected]>
- move jacoco aggregation definitions
- checksum task to be main-utilities

Signed-off-by: Hiroshi Miura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant