Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show files used for segmented match in fuzzy match pane #1226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Dec 19, 2024

split of #963

Pull request type

  • Feature enhancement -> [enhancement]

Which ticket is resolved?

  • BUGS#1251

What does this PR change?

  • Show files to used in segmented match feature on fuzzy match pane

Other information

This comment was marked as outdated.

@miurahr
Copy link
Member Author

miurahr commented Dec 20, 2024

Acceptance test is now flaky.

This comment was marked as outdated.

This comment was marked as resolved.

@miurahr
Copy link
Member Author

miurahr commented Dec 22, 2024

❌ Quality checks failed.

Please look a Gradle Scan page for details: https://gradle.com/s/lzodi3sg3xjhg

It is because @t-cordonnier proposal PR #1223 incresed the lines of search method to limit 150 lines and the commit here ask to add 3 lines. Now master branch has PR #1231 which improve the code with less lines and the fix.
Merging master will fix the checkstyle issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant