-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change label for subsegments #1224
base: master
Are you sure you want to change the base?
Conversation
1ad1c6c
to
ab6ccc7
Compare
Please adjust for master and update with feedbacks from #1220 |
ab6ccc7
to
ea2ab9b
Compare
ea2ab9b
to
13d0a84
Compare
Just done but each time I do a commit I receive alerts from checkstyle. |
Please check |
The change here affects OmegaT UI faced by users. It is mandatory to update the manual page to explain marks and its meanings. @brandelune do you have any suggestions about the manual? |
@t-cordonnier could you please identify in the manual the parts that need updating and suggest a draft ? |
I see nothing about FindMatches.java in my local copy. Are you saying it is intentional? Do you expect us to try to make this method smaller? |
If it is so and checkstyle had reported the error for The errors which the checkstyle reported in CI seems against |
Actually a subsegment is identified as an empty string, which can make confusion with segments coming from project
Pull request type
What does the PR change
Display first entry as file name instead of empty string
Adds new variables for "comes from":
Which ticket is resolved?
RFE#1251