Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2] chore(deps): bump jgit from 6.10.0.202406032230-r to 7.0.0.202409031743-r #1139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 11, 2024

Bumps jgit from 6.10.0.202406032230-r to 7.0.0.202409031743-r.
Updates org.eclipse.jgit:org.eclipse.jgit from 6.10.0.202406032230-r to 7.0.0.202409031743-r

Commits
  • 608a643 JGit v7.0.0.202409031743-r
  • 45689b4 Revert "Remove deprecated
  • b4bdf98 Remove deprecated JschSession#getSftpChannel method
  • 0ae586b Remove deprecated AutoLFInputStream constructors
  • f9a608b Remove deprecated RawParseUtils#UTF8_CHARSET
  • 2a10b41 Remove deprecated FS#setAsyncFileStoreAttributes method
  • 0b531cd FS, FS_Posix: remove deprecated #createNewFile(File) method
  • 8baef22 Remove deprecated lastModified methods using long
  • 88053ee UserAgent: remove deprecated #getAgent, #hasAgent methods
  • d64e092 Remove deprecated Transport#getFilterBlobLimit methods
  • Additional commits viewable in compare view

Updates org.eclipse.jgit:org.eclipse.jgit.ssh.apache from 6.10.0.202406032230-r to 7.0.0.202409031743-r

Commits
  • 608a643 JGit v7.0.0.202409031743-r
  • 45689b4 Revert "Remove deprecated
  • b4bdf98 Remove deprecated JschSession#getSftpChannel method
  • 0ae586b Remove deprecated AutoLFInputStream constructors
  • f9a608b Remove deprecated RawParseUtils#UTF8_CHARSET
  • 2a10b41 Remove deprecated FS#setAsyncFileStoreAttributes method
  • 0b531cd FS, FS_Posix: remove deprecated #createNewFile(File) method
  • 8baef22 Remove deprecated lastModified methods using long
  • 88053ee UserAgent: remove deprecated #getAgent, #hasAgent methods
  • d64e092 Remove deprecated Transport#getFilterBlobLimit methods
  • Additional commits viewable in compare view

Updates org.eclipse.jgit:org.eclipse.jgit.ssh.apache.agent from 6.10.0.202406032230-r to 7.0.0.202409031743-r

Commits
  • 608a643 JGit v7.0.0.202409031743-r
  • 45689b4 Revert "Remove deprecated
  • b4bdf98 Remove deprecated JschSession#getSftpChannel method
  • 0ae586b Remove deprecated AutoLFInputStream constructors
  • f9a608b Remove deprecated RawParseUtils#UTF8_CHARSET
  • 2a10b41 Remove deprecated FS#setAsyncFileStoreAttributes method
  • 0b531cd FS, FS_Posix: remove deprecated #createNewFile(File) method
  • 8baef22 Remove deprecated lastModified methods using long
  • 88053ee UserAgent: remove deprecated #getAgent, #hasAgent methods
  • d64e092 Remove deprecated Transport#getFilterBlobLimit methods
  • Additional commits viewable in compare view

Updates org.eclipse.jgit:org.eclipse.jgit.http.apache from 6.10.0.202406032230-r to 7.0.0.202409031743-r

Commits
  • 608a643 JGit v7.0.0.202409031743-r
  • 45689b4 Revert "Remove deprecated
  • b4bdf98 Remove deprecated JschSession#getSftpChannel method
  • 0ae586b Remove deprecated AutoLFInputStream constructors
  • f9a608b Remove deprecated RawParseUtils#UTF8_CHARSET
  • 2a10b41 Remove deprecated FS#setAsyncFileStoreAttributes method
  • 0b531cd FS, FS_Posix: remove deprecated #createNewFile(File) method
  • 8baef22 Remove deprecated lastModified methods using long
  • 88053ee UserAgent: remove deprecated #getAgent, #hasAgent methods
  • d64e092 Remove deprecated Transport#getFilterBlobLimit methods
  • Additional commits viewable in compare view

Updates org.eclipse.jgit:org.eclipse.jgit.gpg.bc from 6.10.0.202406032230-r to 7.0.0.202409031743-r

Commits
  • 608a643 JGit v7.0.0.202409031743-r
  • 45689b4 Revert "Remove deprecated
  • b4bdf98 Remove deprecated JschSession#getSftpChannel method
  • 0ae586b Remove deprecated AutoLFInputStream constructors
  • f9a608b Remove deprecated RawParseUtils#UTF8_CHARSET
  • 2a10b41 Remove deprecated FS#setAsyncFileStoreAttributes method
  • 0b531cd FS, FS_Posix: remove deprecated #createNewFile(File) method
  • 8baef22 Remove deprecated lastModified methods using long
  • 88053ee UserAgent: remove deprecated #getAgent, #hasAgent methods
  • d64e092 Remove deprecated Transport#getFilterBlobLimit methods
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps `jgit` from 6.10.0.202406032230-r to 7.0.0.202409031743-r.

Updates `org.eclipse.jgit:org.eclipse.jgit` from 6.10.0.202406032230-r to 7.0.0.202409031743-r
- [Commits](eclipse-jgit/jgit@v6.10.0.202406032230-r...v7.0.0.202409031743-r)

Updates `org.eclipse.jgit:org.eclipse.jgit.ssh.apache` from 6.10.0.202406032230-r to 7.0.0.202409031743-r
- [Commits](eclipse-jgit/jgit@v6.10.0.202406032230-r...v7.0.0.202409031743-r)

Updates `org.eclipse.jgit:org.eclipse.jgit.ssh.apache.agent` from 6.10.0.202406032230-r to 7.0.0.202409031743-r
- [Commits](eclipse-jgit/jgit@v6.10.0.202406032230-r...v7.0.0.202409031743-r)

Updates `org.eclipse.jgit:org.eclipse.jgit.http.apache` from 6.10.0.202406032230-r to 7.0.0.202409031743-r
- [Commits](eclipse-jgit/jgit@v6.10.0.202406032230-r...v7.0.0.202409031743-r)

Updates `org.eclipse.jgit:org.eclipse.jgit.gpg.bc` from 6.10.0.202406032230-r to 7.0.0.202409031743-r
- [Commits](eclipse-jgit/jgit@v6.10.0.202406032230-r...v7.0.0.202409031743-r)

---
updated-dependencies:
- dependency-name: org.eclipse.jgit:org.eclipse.jgit
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: org.eclipse.jgit:org.eclipse.jgit.ssh.apache
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: org.eclipse.jgit:org.eclipse.jgit.ssh.apache.agent
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: org.eclipse.jgit:org.eclipse.jgit.http.apache
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: org.eclipse.jgit:org.eclipse.jgit.gpg.bc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 11, 2024
@miurahr
Copy link
Member

miurahr commented Oct 5, 2024

There are so many deprecations. When upgrading jgit library, we need to check team functions with integration test and further reviews.

@miurahr
Copy link
Member

miurahr commented Oct 5, 2024

From commit https://review.gerrithub.io/c/eclipse-jgit/jgit/+/1199821

Signing: refactor interfaces

This is a big API-breaking change cleaning up the signing interfaces.

Initially, these interfaces were GPG/OpenPGP-specific. When EGit added
new signers and signature verifiers that called an external GPG
executable, they were found inadequate and were extended to be able to
pass in the GpgConfig to get access to the "gpg.program" setting.

With the introduction of X.509 S/MIME signing, it was discovered that
the interfaces were still not quite adequate, and the "Gpg" prefix on
the class names were confusing.

Since 7.0 is a major version bump, I'm taking this chance to overhaul
these interfaces from ground up.

For signing, there is a new Signer interface. With it goes a
SignerFactory SPI interface, and a final Signers class managing the
currently set signers. By default, signers for the different signature
types are created from the signer factories, which are discovered via
the ServiceLoader. External code can install its own signers, overriding
the default factories.

For signature verification, exactly the same mechanism is used.

This simplifies the setup of signers and signature verifiers, and makes
it all more regular. Signer instances just get a byte[] to sign and
don't have to worry about ObjectBuilders at all. SignatureVerifier
instances also just get the data and signature as byte[] and don't have
to worry about extracting the signature from a commit or tag, or about
what kind of signature it is.

Both Signers and SignatureVerifiers always get passed the Repository
and the GpgConfig. The repository will be needed in an implementation
for SSH signatures because gpg.ssh.* configs may need to be loaded
explicitly, and some of those values need the current workspace
location.

For signature verification, there is exactly one place in core JGit in
SignatureVerifiers that extracts signatures, determines the signature
type, and then calls the right signature verifier.

Change RevTag to recognize all signature types known in git (GPG, X509,
and SSH).

Change-Id: I26d2731e7baebb38976c87b7f328b63a239760d5
Signed-off-by: Thomas Wolf [email protected]

- JGit 7.0 deprecates GpgSigner interface.
- Bump Java 17 for JGit 7.0

Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr self-requested a review October 5, 2024 09:59
@omegat-org omegat-org deleted a comment from github-actions bot Oct 5, 2024
@miurahr miurahr added this to the 6.2.0 - UI/Process change milestone Oct 5, 2024
@miurahr miurahr changed the title chore(deps): bump jgit from 6.10.0.202406032230-r to 7.0.0.202409031743-r [6.2] chore(deps): bump jgit from 6.10.0.202406032230-r to 7.0.0.202409031743-r Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant