Skip to content

Commit

Permalink
Simplify away condition in ttSave in probCut
Browse files Browse the repository at this point in the history
Remove condition for tte->save in probCut so it always saves on probCut cutoff.

STC:
LLR: 2.95 (-2.94,2.94) <-2.25,0.25>
Total: 47848 W: 12921 L: 12782 D: 22145
Ptnml(0-2): 207, 5340, 12715, 5431, 231
https://tests.stockfishchess.org/tests/view/62a1f7c87bd8e641e44436f7

LTC:
LLR: 2.97 (-2.94,2.94) <-2.25,0.25>
Total: 132736 W: 35895 L: 35881 D: 60960
Ptnml(0-2): 109, 13384, 39360, 13414, 101
https://tests.stockfishchess.org/tests/view/62a2421a7bd8e641e444434f

closes #4069

bench: 5845802
  • Loading branch information
BM123499 authored and vondele committed Jun 16, 2022
1 parent 2d5dcf3 commit 6edc29d
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/search.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -894,12 +894,8 @@ namespace {

if (value >= probCutBeta)
{
// if transposition table doesn't have equal or more deep info write probCut data into it
if (!( ss->ttHit
&& tte->depth() >= depth - 3
&& ttValue != VALUE_NONE))
tte->save(posKey, value_to_tt(value, ss->ply), ttPv,
BOUND_LOWER, depth - 3, move, ss->staticEval);
// Save ProbCut data into transposition table

This comment has been minimized.

Copy link
@PedanticHacker

PedanticHacker Jun 16, 2022

Contributor

This should read // Save the ProbCut data into a transposition table. For the untrained eye, there are missing the and a in the original comment, so I suppose it won't hurt if we add it. Nitpicky, I know, but better than broken English.

This comment has been minimized.

Copy link
@vondele

vondele Jun 16, 2022

Member

maybe some and the ... but that would be pedantic ;-)

This comment has been minimized.

Copy link
@PedanticHacker

PedanticHacker Jun 17, 2022

Contributor

Yes, some seems correct, since not all data is stored at once. Also, the transposition table is the correct expression and not a transposition table, since there’s only one such table.

@vondele, do you mind fixing this?

tte->save(posKey, value_to_tt(value, ss->ply), ttPv, BOUND_LOWER, depth - 3, move, ss->staticEval);
return value;
}
}
Expand Down

1 comment on commit 6edc29d

@Joachim26
Copy link

@Joachim26 Joachim26 commented on 6edc29d Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A @PedanticHacker is THE Movepicker, 5 sigma!
THE Timo[-]Boll, my only follower, is also A Movepicker, 4.5 sigma!
But I should stop!

Please sign in to comment.