Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute Job - Check container stats, regarding cpu & mem usage #786

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Compute Job - Check container stats, regarding cpu & mem usage #786

merged 6 commits into from
Dec 16, 2024

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Dec 6, 2024 •
edited
Loading

Fixes #768

Changes proposed in this PR:

  • limit CPU and Memory when creating container (according to environment settings)

@paulo-ocean paulo-ocean self-assigned this Dec 6, 2024
@paulo-ocean paulo-ocean changed the base branch from main to feature/c2d_docker December 6, 2024 09:46
@paulo-ocean paulo-ocean force-pushed the issue-768-env-cpu-mem branch from ed7cef1 to d8201c3 Compare December 13, 2024 10:13
@paulo-ocean paulo-ocean marked this pull request as ready for review December 13, 2024 10:15
jamiehewitt15
jamiehewitt15 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although there are quite a few lines of commented out code which I sugged we remove if it's not going to be used.

@paulo-ocean
Copy link
Contributor Author

Looks good to me, although there are quite a few lines of commented out code which I sugged we remove if it's not going to be used.

yeah, you're right. Will remove them.. 👍

@paulo-ocean paulo-ocean merged commit ddfc8a5 into feature/c2d_docker Dec 16, 2024
8 checks passed
@paulo-ocean paulo-ocean deleted the issue-768-env-cpu-mem branch December 16, 2024 10:22
@paulo-ocean paulo-ocean restored the issue-768-env-cpu-mem branch December 17, 2024 09:24
@paulo-ocean paulo-ocean deleted the issue-768-env-cpu-mem branch December 17, 2024 09:25
@paulo-ocean paulo-ocean mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C2D Docker: Cpu & Memory Limit
2 participants
@paulo-ocean @jamiehewitt15