-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/admin/update-environment-variables #954
Merged
ryanhopperlowe
merged 6 commits into
obot-platform:main
from
ryanhopperlowe:chore/admin/update-environment-variables
Dec 18, 2024
Merged
Chore/admin/update-environment-variables #954
ryanhopperlowe
merged 6 commits into
obot-platform:main
from
ryanhopperlowe:chore/admin/update-environment-variables
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhopperlowe
requested review from
cjellick,
g-linville,
ivyjeong13,
njhale,
StrongMonkey and
thedadams
December 18, 2024 18:18
ryanhopperlowe
force-pushed
the
chore/admin/update-environment-variables
branch
from
December 18, 2024 18:23
a3613d6
to
e83854d
Compare
ivyjeong13
reviewed
Dec 18, 2024
ivyjeong13
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 lgtm!
StrongMonkey
approved these changes
Dec 18, 2024
…nvironment variables - Added `onUpdate` prop to `AgentEnvSection` for handling updates to environment variables for both agents and workflows. - Updated the `AgentEnvSection` component to include a new UI for displaying and managing environment variables. - Refactored the `SelectList` component to allow optional removal of items and added customizable class names. - Introduced `EnvVariable` type to better structure environment variable data. - Modified API service to filter out empty environment variable entries during updates. This update improves the user experience when managing environment variables in both agents and workflows.
- Replaced static asterisks with a dynamic bullet point representation in the AgentEnvSection for better visual clarity. - Removed unnecessary padding from the SelectList component to streamline the layout.
ryanhopperlowe
force-pushed
the
chore/admin/update-environment-variables
branch
from
December 18, 2024 19:42
08cdd39
to
14bbbdb
Compare
cjellick
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates agent/workflow environment variables
Additional changes