Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/admin/update-environment-variables #954

Conversation

ryanhopperlowe
Copy link
Contributor

@ryanhopperlowe ryanhopperlowe commented Dec 18, 2024

This PR updates agent/workflow environment variables

  • Environment variables now opened in dialog
  • Env values are revealed via an api
  • Env values are updated all at once via an api (no longer updated on change as part of the optimistic form)

Additional changes

  • Removes authenticate button from Workflows
  • Adds env variable section to agent form

image
Screenshot 2024-12-18 at 1 38 44 PM

@ryanhopperlowe ryanhopperlowe force-pushed the chore/admin/update-environment-variables branch from a3613d6 to e83854d Compare December 18, 2024 18:23
Copy link
Contributor

@ivyjeong13 ivyjeong13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 lgtm!

…nvironment variables

- Added `onUpdate` prop to `AgentEnvSection` for handling updates to environment variables for both agents and workflows.
- Updated the `AgentEnvSection` component to include a new UI for displaying and managing environment variables.
- Refactored the `SelectList` component to allow optional removal of items and added customizable class names.
- Introduced `EnvVariable` type to better structure environment variable data.
- Modified API service to filter out empty environment variable entries during updates.

This update improves the user experience when managing environment variables in both agents and workflows.
- Replaced static asterisks with a dynamic bullet point representation in the AgentEnvSection for better visual clarity.
- Removed unnecessary padding from the SelectList component to streamline the layout.
@ryanhopperlowe ryanhopperlowe force-pushed the chore/admin/update-environment-variables branch from 08cdd39 to 14bbbdb Compare December 18, 2024 19:42
@ryanhopperlowe ryanhopperlowe merged commit b811d48 into obot-platform:main Dec 18, 2024
2 checks passed
@ryanhopperlowe ryanhopperlowe deleted the chore/admin/update-environment-variables branch December 18, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants