-
-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more prompt position strategies #1280
feat: more prompt position strategies #1280
Conversation
I agree that it looks a bit weird without adjusting borderchars |
I've added some flexibility to the I've also added some flexibility to the @Conni2461 is this more what you were looking for with the |
skip-checks: true
skip-checks: true
- ensure `prompt` title is visible when `prompt_position="bottom"`
- move title to bottom of picker when `prompt_position="bottom"`
3b5589d
to
e208f50
Compare
@fdschmidt93 I've rebased this PR as requested, and the fixes from #1293 still seem to work well. If you could test this PR and let me know your thoughts, that would be great 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks :)
(just running layout_config bottom_pane
without ivy layout still looks kinda weird, at least for me, but i dont think anyone is doing it. We can fix it if someone reports an issue for that)
|
@pickfire It depends on how you are using the telescope API. If you are using the viml command line api, e.g.: :Telescope find_files theme=get_ivy then you could add :Telescope find_files theme=get_ivy layout_config={height=10} If you are using the lua api, e.g.: require("telescope.builtin").find_files(require("telescope.themes").get_ivy()) then you can add require("telescope.builtin").find_files(require("telescope.themes").get_ivy({layout_config={height=10}})) If you want to create your own theme based on require("telescope.themes").get_custom = function(opts)
opts = vim.tbl_deep_extend("force",{layout_config={height=10}},opts)
return require("telescope.themes").get_ivy(opts)
end and then you can use you custom theme like: :Telescope find_files theme=get_custom or require("telescope.builtin").find_files(require("telescope.themes").get_custom()) |
Wow, this thing is nested multiple layers deep, no wonder I couldn't find it in the docs. I was using |
This PR adds the
prompt_position
option for the following layout stratgies:vertical
bottom_pane
center
vertical
was noted as being "planned" in the codebottom_pane
was requested in this commentEDIT: I have now also added some more flexibility to the
get_dropdown
andget_ivy
themes if the user customises theprompt_position