-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esupports.hop): Add tab drop as option for open_mode #1580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice qol change.
It doesn't work currently, after that's fixed, you can rebase off of main (there was a documentation PR merged just now) and document the keybind with the others.
@benlubas Fixed the mentioned issue and added docs. Let me know if the docs part is good. Could not think of any better keybind using CR, so went with C-t. Let me know if you have any better ideas for that. Thanks! |
I've just added another similar option that uses Let me know your thoughts. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good, but we can't override <C-d>
that's a default vim bind.
This adds
:tab drop
as an option for opening a file when clicking a file link. Tab drop as an option would be helpful to avoid opening a file a new tab, when it has already been open somewhere else.IMO, this could be a replacement for the
tabnew
option itself, as tab drop will open a new tab normally if the same file is already not open. But it can be kept as a separate option as well. Also IMO, never bad to have multiple options :)Do let me know your thoughts on this. If this looks good and needs any documenting, happy to work on that as well.
Thanks!