-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(latex): async image rendering #1397
Conversation
4a1f939
to
6222a8b
Compare
9f96517
to
1cbc6bc
Compare
Code generally looks great! I've managed to find another bug that may or may not be known: other virtual text seems to break positioning within the buffer (e.g. images generated by |
I don't see that behavior, and we definitely account for that in image nvim. Is your image nvim on latest from GitHub? |
I'm on the latest stable luarocks release which I realized happens to be from 144 days ago 😂, perhaps that's due for an update 😅 |
I asked 3rd to cut a release, I think that triggers a luarocks build too, so you can try the rocks version again |
Thanks for getting that release out, that's fixed now at least :) |
does this work for display math and is there a way to make equations bigger? |
screen_cap.mp4
Brings many many improvements to the latex renderer:
$x$
and not have it render a massive disproportionate letterx
for no good reasonNormal
Unfortunately this clobbers all of the changes in #1372, but it improves on most of what's happening there I think. I started this work before that PR went up, and then I got stalled with school and other things.
TODO: