Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of yapf being used by pre-commit #2055

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Nov 16, 2024

Description

On hold for a Conda package of yapf v0.43.0 conda-forge/yapf-feedstock#40

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Nov 16, 2024
@dagardner-nv dagardner-nv self-assigned this Nov 16, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner November 16, 2024 00:57
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait until there is a yapf=0.43 in conda which @cwharris is making a PR for in conda-forge similar to conda-forge/yapf-feedstock#39

@dagardner-nv dagardner-nv added the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Nov 20, 2024
@dagardner-nv
Copy link
Contributor Author

@dagardner-nv dagardner-nv removed the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Jan 7, 2025
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e3a4bf1 into nv-morpheus:branch-25.02 Jan 7, 2025
11 checks passed
@dagardner-nv dagardner-nv deleted the david-update-yapf branch January 7, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants