Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency in DFP Grafana example #1977

Merged

Conversation

efajardo-nv
Copy link
Contributor

Description

  • Dependencies for DFP container were recently moved from examples/digital_fingerprinting/production/conda_env.yaml to conda/environments/examples_cuda-125_arch-x86_64.yaml but python-logging-loki was not included.
  • Add python-logging-loki to example-dfp-prod in dependencies.yaml.
  • Remove conda_env.yaml since it's no longer being used anywhere.

Closes #1917

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 23, 2024
@efajardo-nv efajardo-nv requested review from a team as code owners October 23, 2024 19:31
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnuradhaKaruppiah
Copy link
Contributor

/merge

…is down, not sure if it is permanent or temporary
…phsage/ is down, not sure if it is permanent or temporary"

This reverts commit caa3a74.
@rapids-bot rapids-bot bot merged commit 036d0b4 into nv-morpheus:branch-24.10 Oct 28, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants