Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate all the LFS data needed for running examples within the release container #1976

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

AnuradhaKaruppiah
Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah commented Oct 23, 2024

Move the data files needed for log-parsing from models to examples/data to avoid copying models to the release container

@AnuradhaKaruppiah AnuradhaKaruppiah requested review from a team as code owners October 23, 2024 18:43
Copy link

copy-pr-bot bot commented Oct 23, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AnuradhaKaruppiah AnuradhaKaruppiah changed the base branch from branch-24.06 to branch-24.10 October 23, 2024 18:43
@AnuradhaKaruppiah AnuradhaKaruppiah added bug Something isn't working non-breaking Non-breaking change labels Oct 23, 2024
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

docker/Dockerfile Outdated Show resolved Hide resolved
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

@AnuradhaKaruppiah AnuradhaKaruppiah self-assigned this Oct 24, 2024
I also copy the entire models directory into the release container. But
we only pull down 'datasets' and 'examples' the models directory size is only
370M (vs the 2G if 'all' LFS data were populated).

Some future re-org of data would help. A 'lite-data' option maybe useful
to keep the container size manageable.

Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

@AnuradhaKaruppiah AnuradhaKaruppiah force-pushed the examples-lfs branch 2 times, most recently from 34d960c to 02b1465 Compare October 24, 2024 22:53
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets do copies and not moves.

examples/data/log-parsing-config-20220418.json Outdated Show resolved Hide resolved
examples/data/log-parsing-validation-data-input.csv Outdated Show resolved Hide resolved
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

@AnuradhaKaruppiah
Copy link
Contributor Author

/merge

1 similar comment
@AnuradhaKaruppiah
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit be7e90f into nv-morpheus:branch-24.10 Oct 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants