-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate all the LFS data needed for running examples within the release container #1976
Merged
rapids-bot
merged 4 commits into
nv-morpheus:branch-24.10
from
AnuradhaKaruppiah:examples-lfs
Oct 25, 2024
Merged
Populate all the LFS data needed for running examples within the release container #1976
rapids-bot
merged 4 commits into
nv-morpheus:branch-24.10
from
AnuradhaKaruppiah:examples-lfs
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AnuradhaKaruppiah
added
bug
Something isn't working
non-breaking
Non-breaking change
labels
Oct 23, 2024
/ok to test |
mdemoret-nv
reviewed
Oct 23, 2024
AnuradhaKaruppiah
force-pushed
the
examples-lfs
branch
from
October 24, 2024 15:41
42d5529
to
4856f2b
Compare
/ok to test |
I also copy the entire models directory into the release container. But we only pull down 'datasets' and 'examples' the models directory size is only 370M (vs the 2G if 'all' LFS data were populated). Some future re-org of data would help. A 'lite-data' option maybe useful to keep the container size manageable. Signed-off-by: Anuradha Karuppiah <[email protected]>
Signed-off-by: Anuradha Karuppiah <[email protected]>
AnuradhaKaruppiah
force-pushed
the
examples-lfs
branch
from
October 24, 2024 21:28
4856f2b
to
760ba60
Compare
Signed-off-by: Anuradha Karuppiah <[email protected]>
AnuradhaKaruppiah
force-pushed
the
examples-lfs
branch
from
October 24, 2024 22:23
43e8390
to
2aaa8b1
Compare
/ok to test |
AnuradhaKaruppiah
force-pushed
the
examples-lfs
branch
2 times, most recently
from
October 24, 2024 22:53
34d960c
to
02b1465
Compare
/ok to test |
dagardner-nv
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but lets do copies and not moves.
Signed-off-by: Anuradha Karuppiah <[email protected]>
AnuradhaKaruppiah
force-pushed
the
examples-lfs
branch
from
October 25, 2024 00:24
02b1465
to
2e68d72
Compare
/ok to test |
/merge |
1 similar comment
/merge |
rapids-bot
bot
merged commit Oct 25, 2024
be7e90f
into
nv-morpheus:branch-24.10
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the data files needed for log-parsing from models to examples/data to avoid copying models to the release container