Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SharedProcessPool.terminate() related tests to avoid stack traces and blocking remote-ci #1929

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Remove SharedProcessPool.terminate() related tests to avoid stack traces and blocking remote-ci #1929

merged 3 commits into from
Oct 2, 2024

Conversation

yczhang-nv
Copy link
Contributor

Description

This PR removes SharedProcessPool.terminate() related tests, which is generating stack traces that might cause remote-ci failure
Closes #1926

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 2, 2024
@yczhang-nv yczhang-nv self-assigned this Oct 2, 2024
@yczhang-nv yczhang-nv requested a review from a team as a code owner October 2, 2024 18:56
@yczhang-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1a5c7a7 into nv-morpheus:branch-24.10 Oct 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaKaruppiah AnuradhaKaruppiah AnuradhaKaruppiah approved these changes

Assignees

@yczhang-nv yczhang-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
2 participants
@yczhang-nv @AnuradhaKaruppiah