Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize removing MultiMessage from Morpheus #1886

Merged

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Sep 7, 2024

Description

Should be merged after merging #1803.

The Final step of completely remove MultiMessage from the whole Morpheus repo.

This PR removes MultiMessage and its sub-classes. All occurrences of MultiMessage and its sub-classes in examples and docs are updated to ControlMessage.

Closes #1802

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv
Copy link
Contributor Author

/ok to test

@dagardner-nv
Copy link
Contributor

/ok to test

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found a few small things

@yczhang-nv yczhang-nv requested a review from a team as a code owner September 11, 2024 00:40
@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 64482ee into nv-morpheus:branch-24.10 Sep 12, 2024
12 checks passed
@yczhang-nv yczhang-nv deleted the finalize-remove-multi-message branch September 16, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement to existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: Remove MultiMessage and sub-classes from Morpheus
3 participants