Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Add deprecation message for MultiMessage #1718

Closed
4 tasks done
yczhang-nv opened this issue May 22, 2024 · 0 comments · Fixed by #1719
Closed
4 tasks done

[FEA]: Add deprecation message for MultiMessage #1718

yczhang-nv opened this issue May 22, 2024 · 0 comments · Fixed by #1719
Assignees
@yczhang-nv
Labels
feature request New feature or request

Comments

@yczhang-nv
Copy link
Contributor

yczhang-nv commented May 22, 2024 •
edited
Loading

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

As a part of conversion from MultiMessage to ControlMessage in all stages, Morpheus should generate deprecation warning for users trying to use MultiMessage.

Describe your ideal solution

  • Generate deprecation warning for MultiMessage, on both C++ & Python side.
  • Update documentation to illustrate conversion from MultiMessage to ControlMessage

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@yczhang-nv yczhang-nv added the feature request New feature or request label May 22, 2024
@yczhang-nv yczhang-nv self-assigned this May 22, 2024
@yczhang-nv yczhang-nv mentioned this issue May 22, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue May 31, 2024
@yczhang-nv
Generate deprecation warning for MultiMessage (#1719)
580be43 
- Generate deprecation warning for any usage of `MultiMessage`
- Update documentation to illustrate conversion from `MultiMessage` to `ControlMessage`




Closes #1718 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1719
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yczhang-nv yczhang-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate deprecation warning for MultiMessage yczhang-nv/Morpheus
1 participant
@yczhang-nv