Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Standardize usage of environment variables for constructor args of services #1701

Closed
2 tasks done
mdemoret-nv opened this issue May 15, 2024 · 1 comment
Closed
2 tasks done

[FEA]: Standardize usage of environment variables for constructor args of services #1701

mdemoret-nv opened this issue May 15, 2024 · 1 comment
Assignees
@cwharris
Labels
feature request New feature or request
Milestone
24.10 - Release

Comments

@mdemoret-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

Many of our service wrappers implement different strategies for how args vs environment variables are handled for things like API keys. This causes extra testing and non-uniform functionality.

Describe your ideal solution

Standardize using a common class and pattern. Only the ABC should be tested and all implementations can ignore this functionality.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@mdemoret-nv mdemoret-nv added the feature request New feature or request label May 15, 2024
@cwharris cwharris mentioned this issue May 16, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue May 21, 2024
@cwharris
Use EnvConfigValue for passing env-configured arguments to services (#…
6c722c7 
…1704)

Contributes to #1701

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1704
@mdemoret-nv
Copy link
Contributor Author

@cwharris Is this complete? Please close if it is

@mdemoret-nv mdemoret-nv added this to the 24.10 - Release milestone Aug 16, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwharris cwharris

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
24.10 - Release
Development

No branches or pull requests
2 participants
@cwharris @mdemoret-nv