Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAPIDS 24.02 Upgrade #433

Merged
merged 63 commits into from
Jan 24, 2024
Merged

RAPIDS 24.02 Upgrade #433

merged 63 commits into from
Jan 24, 2024

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Jan 12, 2024 •
edited
Loading

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris added breaking Breaking change feature request New feature or request labels Jan 12, 2024
@cwharris cwharris requested a review from a team as a code owner January 12, 2024 19:28
@cwharris cwharris marked this pull request as draft January 12, 2024 19:28
@cwharris cwharris marked this pull request as ready for review January 16, 2024 18:19
@mdemoret-nv mdemoret-nv added the conda-build Enables running the conda-build step on a PR label Jan 17, 2024
mdemoret-nv
mdemoret-nv approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you look into the CMake 3.27 comments, and verify the conda build works, this should be good to merge.

ci/conda/recipes/libmrc/meta.yaml Outdated Show resolved Hide resolved
ci/conda/recipes/libmrc/meta.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
@cwharris cwharris requested a review from mdemoret-nv January 23, 2024 18:19
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #433 (6404a82) into branch-24.03 (75e43dd) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.03     #433      +/-   ##
================================================
- Coverage         74.03%   74.00%   -0.03%     
================================================
  Files               394      394              
  Lines             13955    13955              
  Branches           1053     1053              
================================================
- Hits              10331    10328       -3     
- Misses             3624     3627       +3
Flag Coverage Δ
cpp 70.47% <100.00%> (-0.03%) ⬇️
py 42.62% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../mrc/include/mrc/memory/resources/detail/arena.hpp 72.48% <100.00%> (ø)
python/mrc/core/subscriber.cpp 88.00% <ø> (ø)

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e43dd...6404a82. Read the comment docs.

@mdemoret-nv mdemoret-nv mentioned this pull request Jan 24, 2024
Closed
@cwharris
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 00dfd7b into nv-morpheus:branch-24.03 Jan 24, 2024
17 checks passed
rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Mar 22, 2024
@e-ago
DOCA Source Stage improvements (#1475)
b939b3d 
Upgrade DOCA source stage API from 2.2 to 2.5 + code restyle

```[tasklist]
### Waiting on
- [ ] nv-morpheus/MRC#433
- [ ] #1468
```

Authors:
  - eago (https://github.com/e-ago)
  - https://github.com/eagonv
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Christopher Harris (https://github.com/cwharris)

URL: #1475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@cwharris cwharris

Labels
breaking Breaking change conda-build Enables running the conda-build step on a PR feature request New feature or request
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwharris @mdemoret-nv