-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Dispatchers to be cached #6373
Conversation
This allows functions which take callable arguments to be cached
@eric-wieser thanks for submitting this, I have queued it for review. |
Co-authored-by: stuartarchibald <[email protected]>
I just tried this patch on some of my higher-order functions and it doesn't crash 👍 but I was noticing a hiccup remaining on my first call to the cached functions. I looked into my |
Thanks for testing this. xref: #6284 is probably also needed. |
Is the plan to wait until @6284 is sorted before putting this in, or are they fine to go in indepedently? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for debugging and fixing this, one minor stylistic thing to resolve else good to go.
Think they can go in independently, but we may need to update tests. |
Co-authored-by: stuartarchibald <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix-ups!
This allows functions which take callable arguments to be cached
Closes #6251