perf_hooks: use kEmptyObject

PR-URL: nodejs/node#43159 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
noslate-project · Oct 10, 2022 · b85023f · b85023f
1 parent a3e6b51
commit b85023f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 6 deletions.
diff --git a/lib/internal/perf/event_loop_delay.js b/lib/internal/perf/event_loop_delay.js
@@ -27,6 +27,10 @@ const {
   kMap,
 } = require('internal/histogram');
 
+const {
+  kEmptyObject,
+} = require('internal/util');
+
 const {
   makeTransferable,
 } = require('internal/worker/js_transferable');
@@ -69,7 +73,7 @@ class ELDHistogram extends Histogram {
  * }} [options]
  * @returns {ELDHistogram}
  */
-function monitorEventLoopDelay(options = {}) {
+function monitorEventLoopDelay(options = kEmptyObject) {
   validateObject(options, 'options');
 
   const { resolution = 10 } = options;

diff --git a/lib/internal/perf/observe.js b/lib/internal/perf/observe.js
@@ -55,6 +55,7 @@ const {
   customInspectSymbol: kInspect,
   deprecate,
   lazyDOMException,
+  kEmptyObject,
 } = require('internal/util');
 
 const {
@@ -215,7 +216,7 @@ class PerformanceObserver {
     this[kCallback] = callback;
   }
 
-  observe(options = {}) {
+  observe(options = kEmptyObject) {
     validateObject(options, 'options');
     const {
       entryTypes,

diff --git a/lib/internal/perf/timerify.js b/lib/internal/perf/timerify.js
@@ -30,6 +30,10 @@ const {
   enqueue,
 } = require('internal/perf/observe');
 
+const {
+  kEmptyObject,
+} = require('internal/util');
+
 function processComplete(name, start, args, histogram) {
   const duration = now() - start;
   if (histogram !== undefined)
@@ -48,7 +52,7 @@ function processComplete(name, start, args, histogram) {
   enqueue(entry);
 }
 
-function timerify(fn, options = {}) {
+function timerify(fn, options = kEmptyObject) {
   validateFunction(fn, 'fn');
 
   validateObject(options, 'options');

diff --git a/lib/internal/perf/usertiming.js b/lib/internal/perf/usertiming.js
@@ -26,7 +26,11 @@ const {
   },
 } = require('internal/errors');
 
-const { structuredClone, lazyDOMException } = require('internal/util');
+const {
+  kEmptyObject,
+  lazyDOMException,
+  structuredClone,
+} = require('internal/util');
 
 const markTimings = new SafeMap();
 
@@ -60,7 +64,7 @@ class PerformanceMark extends InternalPerformanceEntry {
     name = `${name}`;
     if (nodeTimingReadOnlyAttributes.has(name))
       throw new ERR_INVALID_ARG_VALUE('name', name);
-    options ??= {};
+    options ??= kEmptyObject;
     validateObject(options, 'options');
     const startTime = options.startTime ?? now();
     validateNumber(startTime, 'startTime');
@@ -90,7 +94,7 @@ class PerformanceMeasure extends InternalPerformanceEntry {
   }
 }
 
-function mark(name, options = {}) {
+function mark(name, options = kEmptyObject) {
   const mark = new PerformanceMark(name, options);
   enqueue(mark);
   return mark;